On Thu, 24 Feb 2022 08:14:34 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> Christian Hagedorn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make dwarf tag NOT_PRODUCT
>
> src/hotspot/share/utilities/decoder_elf.cpp line 67:
>
>> 65: if (!os::dll_address_to_library_name(pc, filepath, sizeof(filepath),
>> &offset_in_library) || offset_in_library < 0) {
>> 66: // Method not found. offset_in_library should not overflow.
>> 67: log_develop_info(dwarf)("Did not find library for address "
>> INTPTR_FORMAT, p2i(pc));
>
> I know this has been discussed and decided, but I feel uncomfortable about
> this logging here. Also because it sets a precedent for using UL inside
> signal handling.
Note, if you do log, it would be nice to be precise and distinguish between
dll_address_to_library_name returning false and returning an offset outside the
library bounds.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7126
