On Mon, 28 Mar 2022 16:05:03 GMT, Mikael Vidstedt <mik...@openjdk.org> wrote:
>> make/devkit/createWindowsDevkit.sh line 74: >> >>> 72: # Work around the insanely named ProgramFiles(x86) env variable >>> 73: PROGRAMFILES_X86="$($WINDOWS_PATH_TO_UNIX_PATH "$(cmd.exe /c set | sed >>> -n 's/^ProgramFiles(x86)=//p' | tr -d '\r')")" >>> 74: PROGRAMFILES="$($WINDOWS_PATH_TO_UNIX_PATH "$(cmd.exe /c set | sed -n >>> 's/^PROGRAMFILES=//p' | tr -d '\r')")" >> >> This complex dance isn't necessary; it's a special operation for just the >> "ProgramFiles(x86)" variable, since cygwin can't handle environment >> variables with `()` in the name. (See the comment above as well) >> >> I think you will be able to access it with just a simple `$PROGRAMFILES`. > > Good point, thank you. I removed that whole line and verified that creating > the devkit still works. While it did seem to work I realized that `PROGRAMFILES` wasn't converted to a unix path anymore, so I added back that conversion but without the special handling needed for the x86 variable. ------------- PR: https://git.openjdk.java.net/jdk/pull/7974
