On Fri, 15 Apr 2022 12:32:50 GMT, Erik Joelsson <er...@openjdk.org> wrote:

>> JDK-8282769 added support for more ISO-8601 formats, but remove handling of 
>> just a date "YYYY-MM-DD" being present, which is the case for a configure 
>> using --with-source-date=version which uses the date string from 
>> version-numbers.conf.
>> Also, the first date parse had an invalid format string "%FZ %TZ", with too 
>> many Zs.
>> This PR corrects the first date parse to parse a standard ISO-8601 Zulu 
>> date&time: "%FT%TZ"
>> Then it adds the final check for no time being specified.
>> 
>> Signed-off-by: Andrew Leonard <anleo...@redhat.com>
>
> make/autoconf/util.m4 line 243:
> 
>> 241:     # BSD date
>> 242:     # ISO-8601 date&time in Zulu 'date'T'time'Z
>> 243:     timestamp=$($DATE -u -j -f "%FT%TZ" "$2" "+%s" 2> /dev/null)
> 
> You are removing the space between FT and TZ, I'm just curious why and if 
> that is significant.
> EDIT: Never mind me, this looks good.

yes, this is supposed to be parsing an ISO8601 eg.2022-02-09T14:47:36Z, the 
previous JDK-8282769 had an error in this string

-------------

PR: https://git.openjdk.java.net/jdk/pull/8247

Reply via email to