On Tue, 17 May 2022 06:30:03 GMT, David Holmes <dhol...@openjdk.org> wrote:
> Sorry Kim I'm having trouble seeing what change corresponds to (1) ?? The change to CompileJvm.gmk, removing 4996 (deprecation warnings) from the list of disabled warnings. > Also the PR talks only about hotspot, but you're changing the JDK flags as > well. ?? I forgot to mention that in addition to reformatting the JDK flags a little bit to be consistent with the JVM flags changes, I also changed -D_CRT_SECURE_NO_DEPRECATE => -D_CRT_SECURE_NO_WARNINGS. Both are (still) supported and have the same meaning, but the latter is the more "modern" (circa VS2005-ish?) spelling. ------------- PR: https://git.openjdk.java.net/jdk/pull/8718