On Mon, 30 May 2022 00:10:50 GMT, Tim Prinzing <[email protected]> wrote:
>> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
>> a test module with some resources in it for the actual tests that occur at
>> the native level. The native part was switched to c++ instead of c to make
>> it easier to create helper objects that reduce the redundant code performing
>> error checking. The two helper classes InstanceCall and StaticCall were
>> placed in an include file called CallHelper.hpp. The main part of the tests
>> are in exeNullCallerTest.cpp, and there is a separate function for each of
>> the bug reports.
>
> Tim Prinzing has updated the pull request incrementally with one additional
> commit since the last revision:
>
> problem with iostream on Windows, use printf
test/jdk/jdk/nullCaller/CallHelper.hpp line 176:
> 174: }
> 175:
> 176: // call an method returning an object checking for exceptions and
`s/an method/a method/`
test/jdk/jdk/nullCaller/exeNullCallerTest.cpp line 29:
> 27: * ResourceBundle::getBundle may throw NPE when invoked by JNI code with
> no caller frame
> 28: */
> 29: void JDK_8280902(JNIEnv* env) {
A descriptive method name would be more helpful than the bug ID, for example,
`getResourceBundle` and `registerClassLoaderAsParallelCapable`
test/jdk/jdk/nullCaller/exeNullCallerTest.cpp line 49:
> 47:
> 48: // check the message
> 49: if (std::string("Hello!") != env->GetStringUTFChars(msg,NULL)) {
nit: a space after the comma `(msg, NULL)` consistent with the format in this
local file.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8934
