On Fri, 10 Jun 2022 07:09:28 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Apparently that was not a legal reference to actions/checkout. Try another
>> way.
>
> .github/actions/get-bootjdk/action.yml line 26:
>
>> 24: #
>> 25:
>> 26: name: 'Get BootJDK'
>
> Here and later, polishing: "BootJDK" -> "boot JDK"?
I think we've mostly been using "BootJDK" as a specialized term in the build
system, but we've not been very consistent about it:
ihse@mercurius:~/git/jdk-ALT/open/make$ gr -i "Boot JDK" | wc
61 673 5606
ihse@mercurius:~/git/jdk-ALT/open/make$ gr -i BootJDK | wc
79 298 5947
but I can switch it out to `Boot JDK` if that makes you happier.
> .github/actions/get-msys/action.yml line 26:
>
>> 24: #
>> 25:
>> 26: name: 'Get msys'
>
> Here and later, polishing: call it consistently "msys2" or "MSYS2"?
The official name is `MSYS2` so I've tried to use that, unless lower case were
needed/preferred to keep things consistent. I'll check over the code to see
what places I've missed. (I agree that in this description it should definitely
be MSYS2).
-------------
PR: https://git.openjdk.org/jdk/pull/9063
