On Mon, 25 Jul 2022 21:45:30 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Harold Seigel has updated the pull request incrementally with one additional >> commit since the last revision: >> >> SIGFPE change > > src/hotspot/os/posix/signals_posix.cpp line 843: > >> 841: // Compare both sigaction structures (intelligently; only the members >> we care about). >> 842: // Ignore if the handler is our own crash handler. >> 843: if (!are_handlers_equal(&act, expected_act) && > > Pre-existing nit: really this should be called `are_actions_equal`. The poor > naming is clearer when you now follow this with `HANDLER_IS`. Thanks for the suggestion. Function are_handlers_equal() is renamed to are_actions_equal() in the latest commit. ------------- PR: https://git.openjdk.org/jdk/pull/9631
