On Thu, 4 Aug 2022 22:59:34 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove bundle artifacts
>
> .github/workflows/main.yml line 85:
>
>> 83: input='${{ secrets.JDK_SUBMIT_PLATFORMS }}'
>> 84: else
>> 85: echo 'Internal error in GHA'
>
> @magicus isn't this check too strict? The Corretto team runs these steps for
> all our PRs to make sure we will not break the OpenJDK later if our fix will
> be proposed upstream. But this line prevents us to run it by the
> "pull_request". I can apply the local patch for sure, but probably this check
> can be relaxed?
> Something like:
>
> elif [[ $GITHUB_EVENT_NAME == pull_request ]]; then
> input='${{ secrets.JDK_SUBMIT_PLATFORMS }}'
> else
@mrserb possibly related:
[JDK-8291444](https://bugs.openjdk.org/browse/JDK-8291444)
-------------
PR: https://git.openjdk.org/jdk/pull/9063
