On Mon, 15 Aug 2022 14:21:18 GMT, Thomas Stuefe <[email protected]> wrote:
>> Why? `arguments.hpp` transitively includes it. > >> Why? `arguments.hpp` transitively includes it. > > I thought the rule is not to rely on transitive includes. Unless it is an > explicit umbrella header. If you need it, include it - that way if someone > changes the include tree, we minimize the possibility of seemingly unrelated > build errors. Ah, you mean because we use `RewriteBytecodes`, I see. Yes, we need the explicit header. My additional patch uses `UseSharedSpaces`, so it needs the additional include too. ------------- PR: https://git.openjdk.org/jdk/pull/9869
