On Thu, 18 Aug 2022 12:48:30 GMT, Harold Seigel <[email protected]> wrote:

> Please review this small change to add a test that option -XX:+CheckJNICalls 
> shows changed signal handlers.  This new test is a copy of the recently 
> deleted TestPosixSig.java with small changes.  This version of the test only 
> checks that handlers were changed for SIGFPE and SIGILL signals.
> 
> The test was tested using Mach5 to run it on Linux, Mac OS, and Windows.
> 
> Thanks, Harold

LGTM. Thanks for this test.

test/hotspot/jtreg/runtime/posixSig/libTestPsig.c line 38:

> 36: 
> 37:     printf( " HANDLER (1) " );
> 38: }

Nit: handler could be file scope static, and does not need extern "C"

-------------

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9919

Reply via email to