On Tue, 23 Aug 2022 16:56:08 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> That doesn't work because `check-jvm-feature` requires `JVM_VARIANT` to be >> set, but `CreateCDSArchive` is not called in a context where `JVM_VARIANT` >> is set. ( `JVM_VARIANT` is set only in a few specific places in Main.gmk, >> etc). >> >> One option is to change the foreach loop a few lines below to: >> >> >> $(foreach JVM_VARIANT, $(JVM_VARIANTS), \ >> $(eval $(call CreateCDSArchive,)) \ >> ) >> >> >> But I've not seen `JVM_VARIANT` being used this way, so I am a little >> hesitant about doing it. > > Is the CDS archive dumped in a JVM variant specific way? If so, then it would > make sense to dump it for each configured variant. Yes, it's dumped in a different directory depending on the JVM variant. The contents of the CDS archive is specific to the particular libjvm.so that created the archive. ------------- PR: https://git.openjdk.org/jdk/pull/9984
