On Mon, 19 Sep 2022 12:48:21 GMT, Erik Joelsson <[email protected]> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Should be "literal"
>
> make/autoconf/jdk-options.m4 line 481:
> 
>> 479: AC_DEFUN_ONCE([JDKOPT_SETUP_JMOD_OPTIONS],
>> 480: [
>> 481:   AC_ARG_WITH(jmod-compress, [AS_HELP_STRING([--with-jmod-compress],
> 
> I would recommend using UTIL_ARG_WITH here instead. I would also prefer if 
> the default was specified in configure (using the DEFAULT argument to 
> UTIL_ARG_WITH) so that it's visible in the help output and printed in the 
> configure log for user transparency.

Changed!

-------------

PR: https://git.openjdk.org/jdk/pull/10214

Reply via email to