On Thu, 29 Sep 2022 00:50:42 GMT, Mikael Vidstedt <[email protected]> wrote:
>> The OpenJDK build system does not support building when the source code
>> resides on a path that contains a space. This requirement is documented in
>> the build instructions but not enforced by the configure script.
>>
>> This change adds an explicit checks to the wrapper `configure` script that
>> fail the build if the source code to be built is located in a directory
>> who's path contains a space character or the build path cannot be determined.
>>
>> Includes some idiom modernization and shell scripting best practices changes.
>
> configure line 29:
>
>> 27:
>> 28: # Get an absolute path to this script, since that determines the
>> top-level directory.
>> 29: source_path="${BASH_SOURCE[0]:-$0}"
>
> Can we (do we want to) rely the shell running this script itself supporting
> BASH_SOURCE and/or other potential bash-isms?
It is explicitly a bash script so I believe it is OK to use bash-isms. I
usually write pure POSIX scripts because of the issues with MacOS compatibility
(they use a very old GPLv2 version of BASH) and compatibility with other shells
but didn't feel it was an issue here.
-------------
PR: https://git.openjdk.org/jdk/pull/10477
