On Tue, 4 Oct 2022 17:25:07 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
> WRT the redundant copy. I wanted to avoid the use site having to have some > `if` that checks whether we're running on Windows to decide which file > `$1_COMPILE_TARGET` should depend on. Copying allows always depending on the > fixed file. You are indeed correct and having a single code path is also a desirable attribute. Had this been in a more performance sensitive location, I would have still preferred to avoid the copy, but I think once per Java compilation unit is rare enough to not be an issue, especially since it's just unnecessary on non-windows. ------------- PR: https://git.openjdk.org/jdk/pull/10560
