On Tue, 22 Nov 2022 21:02:58 GMT, Christoph Langer <[email protected]> wrote:
>> With this PR I'd like to make it easier to use dedicated installations of >> Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode >> globally via `xcode-select`. >> >> I propose adding a new configure flag `--with-xcode-path` that takes the >> path to an Xcode installation. If the option is set, this path is expanded >> to a valid `TOOLCHAIN_PATH`. >> >> Furthermore, I fix detection of xcodebuild and correctly setting the sysroot >> from the toolchain by moving `AC_SUBST(TOOLCHAIN_PATH)` before calling >> `BASIC_SETUP_XCODE_SYSROOT` and honoring `TOOLCHAIN_PATH` in >> `BASIC_SETUP_XCODE_SYSROOT` in the case when no devkit is specified. As I >> see it, this is a viable fix, even if not introducing `--with-xcode-path`. > > Christoph Langer has updated the pull request incrementally with one > additional commit since the last revision: > > Regenerate once more Marked as reviewed by ihse (Reviewer). ------------- PR: https://git.openjdk.org/jdk/pull/11113
