On Tue, 22 Nov 2022 19:21:51 GMT, Matias Saavedra Silva <matsa...@openjdk.org> wrote:
>> The -XX:+AutoCreateSharedArchive flag was implemented in JDK 19, however, >> this flag doesn't work across JDK 19 and 20. >> >> Expected: JDK 20 should recreate the specified CDS archive >> Actual: JDK 20 cannot recognize the archive file and gives up >> >> The new field from GenericCDSFileMapHeader is now in FileMapHeader. Verified >> with tier 1-4 tests. > > Matias Saavedra Silva has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains eight additional > commits since the last revision: > > - Merge branch 'master' into autoCreateSharedArchive_8296754 > - Added newline to end of test > - Removed unused import > - Test now passes > - Changed whitespace and comment > - Adjusted whitespace > - Added test > - 8296754: AutoCreateSharedArchive in JDK 20 is not compatible with JDK 19 Approved latest changes again. Matias had to do second force-push which reverted the effects of the first force-push. ------------- Marked as reviewed by iklam (Reviewer). PR: https://git.openjdk.org/jdk/pull/11148
