Directly cc'ing build-dev. Once this became a build-only fix the build
team should have been included just so they are aware of the change.
Cheers,
David
On 6/12/2022 12:52 am, Tyler Steele wrote:
On Fri, 2 Dec 2022 17:43:46 GMT, Tyler Steele <[email protected]> wrote:
Recent changes (https://github.com/openjdk/jdk/pull/10745) to ResourceObj, have
caused the build to fail on AIX. This is because the AIX compiler (xlclang++)
complains if 'operator new' is called on a class where 'operator delete' is
marked as deleted (ie. `operator delete(void*) = delete`). This is the case
even when 'operator new' is explicitly defined.
It is my understanding that future PRs will migrate many instances of
ResourceObj to AnyObj (or other classes), so it's possible this work-around
could be removed in the future. An alternate solution is to change ResouceObj
to AnyObj in 61 places. This alternative solution works since AnyObj defines
both 'operator new' and 'operator delete'. This is both a much bigger change,
and doesn't provide any additional benefit if instances of ResourceObj are
being reviewed anyway.
Tyler Steele has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains one new commit
since the last revision:
Add fno-exceptions to xlc
Thanks all.
-------------
PR: https://git.openjdk.org/jdk/pull/11443
