On Mon, 23 Jan 2023 19:39:44 GMT, Justin King <[email protected]> wrote:
>> Update some custom launchers to set the default ASan options, without it the >> tests fail due to incompatibility with LSan. Additionally adds `-fno-common` >> for ASan build, as suggested by the docs. > > Justin King has updated the pull request incrementally with two additional > commits since the last revision: > > - Remove extra whitespace > > Signed-off-by: Justin King <[email protected]> > - Always link ASan default options to any test launchers > > Signed-off-by: Justin King <[email protected]> Marked as reviewed by ihse (Reviewer). make/common/TestFilesCompilation.gmk line 92: > 90: NAME := $$(unprefixed_name), \ > 91: TYPE := $$($1_COMPILATION_TYPE), \ > 92: EXTRA_FILES := $$(file) $$($1_EXTRA_FILES), \ Since you are adding a new argument to this function, can you just briefly document it in the list of arguments given at the top of the function (macro) definition? (Sorry for the slow response; apart from this documentation issue, it looks good). ------------- PR: https://git.openjdk.org/jdk/pull/12082
