On Sat, 4 Feb 2023 09:42:57 GMT, Yasumasa Suenaga <[email protected]> wrote:
> C4819 warnings were reported when I tried to build JDK on Windows with VS2022. > This PR contains changes both HotSpot and client libraries. Let me know if > they should be separated. > > * HotSpot > * stubGenerator_x86_64_poly.cpp > * elfFile.hpp > * libfontmanager > * hb.hh > * libfreetype > * afblue.c > > I added C4819 to `DISABLED_WARNINGS_microsoft` for libfontmanager and for > libfreetype because they are 3rd-party libraries. Sorry Yasumasa, but I'd much prefer to see this split into three sub-tasks (or issues) just so we can keep the issues more clearly separated. IIUC for stubGenerator_x86_64_poly.cpp we have a multiplication symbol instead of an ascii 'x' (likely pasted from a word processing document). For elfFile.hpp there are smart-quotes instead of ascii " Thanks. ------------- Changes requested by dholmes (Reviewer). PR: https://git.openjdk.org/jdk/pull/12427
