On Thu, 16 Feb 2023 06:33:08 GMT, Ioi Lam <[email protected]> wrote:

> As a general comment, the bug title should be to the point. "Look suspicious" 
> contains no information. It looks like you are changing the optimization 
> level, so the bug title should reflect that.

I agree. But let me expand the point a bit: It is fully okay for an *issue in 
JBS* to have a title like "flags look sus". Bug reports can be vague and be as 
much about further research. But once the research is done, the bug should 
either be closed (if the research ended in "it's ok, no change needed"), or it 
should be retitled to describe the actual changes needed.

So the requirement to match PR and bug title is a good one, but we should be 
liberal with updating bug titles in JBS, when more knowledge about the problem 
has appeared.

And, as another general rule, if some code is still in the "research" phase, 
but you still want to open a PR, it should be opened as a draft. That way you 
clearly signal that you do not intend to integrate the changes as-is, but are 
looking for feedback on an incomplete fix.

So, an alternative to renaming the PR/JBS issue, is to move this PR to draft. 
And perhaps make it even clearer by renaming it "WIP: ....". That makes the bug 
impossible to integrate, and will give folks peace of mind of knowing that this 
won't suddenly be integrated without further discussion.

-------------

PR: https://git.openjdk.org/jdk/pull/12073

Reply via email to