On Thu, 23 Feb 2023 19:18:32 GMT, Julian Waters <[email protected]> wrote:

> pandoc.exe follows the Windows CRLF format of newlines, whereas we only ever 
> have LF in our documentation files. As a result whenever we generate html the 
> resulting html files will all be mangled, even if there was no change to the 
> corresponding markdown file. This passes --eol=lf to pandoc so that it always 
> uses LF no matter the platform, since we never ever seem to use (or even want 
> to use) CRLF at all, so that pandoc will exhibit consistent behaviour on all 
> platforms
> 
> pandoc by default uses the --eol=native option, which is LF on macOS, Linux 
> and UNIX, so this change will not affect their html generation whatsoever, 
> but will make the lives of Windows JDK developers and _especially_ JDK 
> developers working with MSYS2 a hell of a lot easier (*cries internally)

This pull request has now been integrated.

Changeset: 7d8b8ba9
Author:    Julian Waters <[email protected]>
URL:       
https://git.openjdk.org/jdk/commit/7d8b8ba9c46475ededcae7db6c841b25fa83d167
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8303131: pandoc.exe mangles all processed html files

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/jdk/pull/12733

Reply via email to