lgtm
Le lun. 27 févr. 2023 à 17:17, Jayathirth D V <j...@openjdk.org> a écrit : > > Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level > of gcc optimizations from -O1 level for libawt build. This improved our > J2DBench performance numbers in some options considerably. > > > > Recent changes done under https://bugs.openjdk.org/browse/JDK-8299337 > causes difference in generated code by gcc and this is resulting in > performance regression for bimg_misc-* J2DBench options in our performance > servers. Under https://bugs.openjdk.org/browse/JDK-8299337 we have just > removed unused variables and it is a cleanup task. > > > > We can force gcc to generate position independent code by using -fpic > option.Also i have removed -fgcse-after-reload option for gcc, because this > is by default covered under -O3 level of optimization introduced under > https://bugs.openjdk.org/browse/JDK-8264846. > > > > With this change bimg_misc-* J2DBench option performance regression is > resolved and there are no regression in other options of J2DBench or > SwingMark and it is verified in our performance servers. > > Jayathirth D V has updated the pull request incrementally with one > additional commit since the last revision: > > Update comment > > ------------- > > Changes: > - all: https://git.openjdk.org/jdk/pull/12761/files > - new: https://git.openjdk.org/jdk/pull/12761/files/0c39e4c3..e8d25674 > > Webrevs: > - full: https://webrevs.openjdk.org/?repo=jdk&pr=12761&range=01 > - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12761&range=00-01 > > Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod > Patch: https://git.openjdk.org/jdk/pull/12761.diff > Fetch: git fetch https://git.openjdk.org/jdk pull/12761/head:pull/12761 > > PR: https://git.openjdk.org/jdk/pull/12761 >
