On Thu, 9 Mar 2023 11:35:22 GMT, Julian Waters <[email protected]> wrote:
>> Was: sunmscapi.dll cannot compile with Visual C++
>>
>> `-Zc:wchar_t-` has, until now, been passed to switch off wchar_t as a
>> distinct C++ type when compiling with Visual C++ so jchar and wchar_t are
>> typedef'd to shorts on Windows. After some examination it appears this flag
>> is not actually needed for almost every source file that we have, barring
>> security.cpp, so we could try to remove it and make Windows code behave more
>> like regular C++, since casting between wchar_t and jchar does not appear to
>> happen very often (only appearing in one file!). wchar_t in Standard C is a
>> typedef and is never affected by this flag, and if `-Zc:wchar_t` is enabled
>> for C code, it is simply ignored
>
> Julian Waters has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains four additional
> commits since the last revision:
>
> - Merge branch 'openjdk:master' into patch-7
> - -Zc:wchar_t should be enabled
> - Remove explicit wchar_t check in jdk.accessibility
> - sunmscapi.dll cannot compile under permissive-
src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp line 544:
> 542: {
> 543: if ((dwKeySpec & CERT_NCRYPT_KEY_SPEC) ==
> CERT_NCRYPT_KEY_SPEC) {
> 544: PP("CNG %lld", (long long) hCryptProv);
What error were you seeing here before your changes?
-------------
PR: https://git.openjdk.org/jdk/pull/12907
