On Thu, 9 Mar 2023 15:31:51 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address Review and add extra comments > > doc/ide.md line 94: > >> 92: indexing the Java sources in the JDK (see below), is to enable dark mode >> 93: before doing so. Trust us, it looks much better than Eclipse's default >> look >> 94: and feel. ;) > > Does this change how Eclipse functions with our sources in any way, or is it > just your opinion that it looks better? If the latter, then I don't think it > really belongs in this document. Ah, was hoping that I could leave a personal touch in there. No matter, I'll remove it if required > make/ide/eclipse/CreateWorkspace.gmk line 40: > >> 38: include hotspot/lib/JvmFlags.gmk >> 39: >> 40: # Warning: This file does not have the best formatting! > > Is this still true? If so, we should fix that so the comment can be removed. > > After having read through the file. I find quite a few places where broken up > lines have 2 space indentation instead of 4. (See > https://openjdk.org/groups/build/doc/code-conventions.html) Fixing this > should be pretty quick and simple and will greatly improve readability at > least for me and Magnus. I will mark some of the typical cases for you. Not anymore, at least I would hope not. This was back when everything in the file was completely generated by handwritten printing and is not up to date any longer ------------- PR: https://git.openjdk.org/jdk/pull/10853
