On Wed, 12 Apr 2023 17:07:40 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Please review this patch that fixes and re-enables a few warnings in libawt >> compilation. >> >> Verified that debug and release builds finish successfully on Win, Mac and >> Linux. Also verified that client libs tests still pass. > > Daniel Jeliński has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 10 commits: > > - Merge remote-tracking branch 'origin' into awt-warning-cleanup > - Merge remote-tracking branch 'origin' into awt-warning-cleanup > - Copyright > - snprintf > - cl analyze > - Fix non-debug warning > - Restore suppressions > - Fix warnings > - WIP: reenable awt warnings > - Fix warnings make/modules/java.desktop/lib/Awt2dLibraries.gmk line 141: > 139: DISABLED_WARNINGS_gcc_SurfaceData.c := unused-value, \ > 140: DISABLED_WARNINGS_gcc_TransformHelper.c := sign-compare, \ > 141: DISABLED_WARNINGS_clang_awt_ImagingLib.c := > deprecated-non-prototype, \ I see you declared the functions as `inline`, it was probably the intention for declaring them in the header file. Did it not resolve `deprecated-non-prototype` warning? If not, did you submit another bug to address it? src/java.desktop/share/native/common/awt/debug/debug_mem.c line 72: > 70: */ > 71: static DMemState DMemGlobalState; > 72: const DMemState * DMemStatePtr = &DMemGlobalState; As far as all's aligned, should there be another space to align the type names? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/11841#discussion_r1164620755 PR Review Comment: https://git.openjdk.org/jdk/pull/11841#discussion_r1164619094
