Re: RFR: 8305089: Implement missing socket options on AIX [v4]

[Varada M]

On Fri, 14 Apr 2023 09:10:22 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:

>> Varada M has updated the pull request with a new target base due to a merge 
>> or a rebase. The pull request now contains six commits:
>> 
>>  - Merge branch 'master' into aix_socket_options
>>  - Updated copyright year
>>  - Update to copyright year
>>  - AIX socket options
>>  - aix socket options
>>  - AIX Socket Options
>
> src/jdk.net/aix/native/libextnet/AIXSocketOptions.c line 130:
> 
>> 128: 
>> 129:     if ((rv=getsockopt(fd, SOL_SOCKET, SO_PEERID, &cred_info, &len)) < 
>> 0) {
>> 130:         handleError(env, rv, "get  failed");
> 
> Is the double space after "get  " intended here, or is something missing from 
> the error message?

It is intended

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13240#discussion_r1166685715