On Fri, 21 Apr 2023 01:50:48 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed doc > > doc/testing.md line 385: > >> 383: Sets the `-testThreadFactory` for JTReg. Is should be the name of class >> implementing ThreadFactory >> 384: and located in `test/jtreg_test_thread_factory/'. The plugins are built >> as a part of test image. >> 385: Currently, the only `Virtual` factory which executes test method main >> in virtual thread is implmented. > > Hello Leonid, there are some typos in this section. Perhaps consider changing > it to: > >> >> Sets the `-testThreadFactory` for JTReg. It should be the fully qualified >> classname of a class which implements `java.util.concurrent.ThreadFactory`. > One such implementation class, named `Virtual`, is currently part of the JDK > build in the `test/jtreg_test_thread_factory/` directory. This class gets > compiled during the test image build. > The implementation of the `Virtual` class creates a new virtual thread for > executing each test class. > > Does that sound accurate? Thank you for feedback. I updated doc. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13432#discussion_r1173233068
