On Wed, 3 May 2023 21:32:54 GMT, Martin Doerr <mdo...@openjdk.org> wrote:
> I'm getting build warnings on all linux platforms with gcc-11.3.0:
>
> ```
> src/hotspot/share/gc/z/zDriver.cpp:84:13: error: In the GNU C Library,
> "minor" is defined
> by <sys/sysmacros.h>. For historical compatibility, it is
> currently defined by <sys/types.h> as well, but we plan to
> remove this soon. To use "minor", include <sys/sysmacros.h>
> directly. If you did not intend to use a system-defined macro
> "minor", you should undefine it after including <sys/types.h>. [-Werror]
> 84 | ZDriverMinor* ZDriver::minor() {
> ```
That's unfortunate as minor and major are quite central to Generational ZGC and
having to rename those functions will make the code look worse. I wonder if we
should undef minor and major where needed.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13771#issuecomment-1533806231
