On Tue, 13 Jun 2023 22:02:12 GMT, Erik Joelsson <[email protected]> wrote:
>> Autoconf is emitting this warning after >> [JDK-8307573](https://bugs.openjdk.org/browse/JDK-8307573): >> >> stdin:85: warning: AC_REQUIRE: `PLATFORM_EXTRACT_TARGET_AND_BUILD' was >> expanded before it was required >> stdin:85: >> http://www.gnu.org/software/autoconf/manual/autoconf.html#Expanded-Before-Required >> /home/erik/git/jdk/open/make/autoconf/platform.m4:644: >> PLATFORM_SETUP_OPENJDK_BUILD_AND_TARGET is expanded from... >> stdin:85: the top level >> >> This is caused by using `AC_DEFUN_ONCE` and `AC_REQUIRE` in the wrong way. >> In the OpenJDK configure script, we use a more imperative model of >> explicitly calling `AC_DEFUN` macros in most situations. This is mostly done >> due to how easy it is to get the other model wrong, especially when the >> models are mixed. The simple solution here is to just change >> `PLATFORM_CHECK_DEPRECATION` to an `AC_DEFUN` macro and remove the >> `AC_REQUIRE` call. >> >> When verifying the fix, I noticed that the check isn't currently working. At >> least I am still able to configure windows-x86 with no warning or error. >> With this fix, the error is printed as expected. This makes me wonder if the >> original change ever worked. >> >> I'm also adding the deprecation override configure arg to jib-profiles.js to >> make it possible to still configure windows-x86 using Jib at Oracle. We >> aren't doing that regularly, but as long as the configuration is there, it >> should at least work. > > Erik Joelsson has updated the pull request incrementally with one additional > commit since the last revision: > > Copyright year Marked as reviewed by mikael (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/14459#pullrequestreview-1478199064
