On Thu, 13 Jul 2023 07:41:00 GMT, David Holmes <dhol...@openjdk.org> wrote:

> [JDK-8295974](https://bugs.openjdk.org/browse/JDK-8295974) modified 
> print_jni_stack to print the native stack when there are no Java frames. To 
> do that it used VMError::print_native_stack, however that function is only 
> for platforms that support stack-walking by following frames, on other 
> platforms (i.e. Windows and AIX) we need to use 
> os::platform_print_native_stack.
> 
> I'm not trying to consolidate the different versions of the stack printing 
> code in this PR so that it is more easily backported to where 
> [JDK-8295974](https://bugs.openjdk.org/browse/JDK-8295974) was.
> 
> The test has been updated to work on Windows (taking advantage of two other 
> recent enhancements - see JBS for details).
> 
> Testing:
> - tiers 1-3 (sanity)
> -  TestNativeStack regression test
> 
> Thanks

This pull request has now been integrated.

Changeset: c2f421b8
Author:    David Holmes <dhol...@openjdk.org>
URL:       
https://git.openjdk.org/jdk/commit/c2f421b8bf920665e05bbbb56bc4d7f55430d5e1
Stats:     51 lines in 5 files changed: 43 ins; 1 del; 7 mod

8311541: JavaThread::print_jni_stack doesn't support native stacks on all 
platforms

Reviewed-by: pchilanomate, shade, stuefe

-------------

PR: https://git.openjdk.org/jdk/pull/14862

Reply via email to