On Tue, 1 Aug 2023 12:50:47 GMT, Andreas Steiner <d...@openjdk.org> wrote:
>> Add the default include location(/opt/freeware/include/) for cups on AIX.
>> With this set the additional configure parameter --with-cups-include can be
>> removed, which was needed on AIX.
>
> Andreas Steiner has updated the pull request incrementally with one
> additional commit since the last revision:
>
> set default cups include location if with_cups is not set only, update
> copyright year
Hm, I still think it's clearer to have the AIX default cups check in the next
section after `if test "x$CUPS_FOUND" = xno; then`.
Currently, if somebody sets both, --with-cups= and --with-cups-include,
with-cups-include gets precedence. The problem is only theoretical, I guess but
I'd find it better if it were:
if test "x${with_cups}" != x; then
...
elif test "x${with_cups_include}" != x; then
...
fi
and then
if test "x$CUPS_FOUND" = xno; then
Are the cups headers installed in the default /usr/include location?
if aix
...
else
...
fi
fi
-------------
PR Review: https://git.openjdk.org/jdk/pull/15100#pullrequestreview-1557168109
