On Thu, 17 Aug 2023 07:52:07 GMT, Christian Hagedorn <chaged...@openjdk.org> 
wrote:

>> Coleen Phillimore has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   put sizes back to uint32_t.
>
> src/hotspot/share/utilities/elfFuncDescTable.cpp line 49:
> 
>> 47: }
>> 48: 
>> 49: address ElfFuncDescTable::lookup(Elf64_Addr index) {
> 
> I think this could be `Elf_Addr` to be platform-specific. `Elf_Word` is 
> either `Elf32_Word` or `Elf64_Word`, depending on the platform. But both are 
> `typedefs` for `uint32_t` for some reason. That's why it must have complained 
> here.

Ok, thanks, I'll change that.  I picked the type that the compiler told me, but 
this would be better on 32 bit platforms.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15233#discussion_r1297137694

Reply via email to