On Fri, 25 Aug 2023 13:20:09 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove unnecessary import in Arrays.java > > make/modules/java.base/Lib.gmk line 239: > >> 237: >> ################################################################################ >> 238: >> 239: ifeq ($(call isTargetOs, linux)+$(call isTargetCpu, >> x86_64)+$(INCLUDE_COMPILER2), true+true+true) > > Is there a reason for this to only be supported on Linux? Hi Erik, The reason this PR is focused on Linux is because the AVX512 sort and partitioning routines are based on Intel’s x86-simd-library (https://github.com/intel/x86-simd-sort) which was originally developed with GCC as the target compiler. Thus, this PR has restricted itself to Linux as the code was tested using GCC/Linux platforms. Additionally, the x86_64 library is compiled for AVX512 using file specific compilation pragmas (`#pragma GCC target("avx512dq", "avx512f")`). This feature is absent for Windows/MSVC++ compiler.” Thanks, Vamsi ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14227#discussion_r1308027470
