On Fri, 1 Sep 2023 13:39:58 GMT, Matthias Baesken <[email protected]> wrote:
>> make/autoconf/lib-x11.m4 line 90: >> >>> 88: fi >>> 89: # Also remove the -R setting for devkit usage >>> 90: if test "x$with_devkit" != "x" && test "x$with_devkit" != "xno"; >>> then >> >> This should rather check if `$SYSROOT` has a value and should also check >> that `$x_libraries` is `NONE` (see how it's done on line 64). A sysroot can >> be configured without a devkit, and if we find the X libraries in the >> sysroot, then we shouldn't add an -R path. If however a user needs to >> specifically point out the x libraries, I think we need to trust the built >> in macros as the user may have them in a non standard place. >> >> Can we combine the conditionals to avoid having to repeat the if body? > > Hi Erik, unfortunately `x_libraries` is already modified in the SYSROOT > cases (see line 64 and below) , so can I check that `$x_libraries` is `NONE` > or should I cache somehow the original value ? Ah you are right. Yes, we will need a local variable expressing if x_libraries was set by the user (as opposed to based on the sysroot). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15534#discussion_r1313094169
