On Thu, 14 Sep 2023 15:49:36 GMT, Christoph Langer <clan...@openjdk.org> wrote:
>> While building openjdk on aix, we see this build-fail error: >> >> The fopen system call failed on file >> -f/home/.....etce4tcetc...../_BUILD_LIBJDWP_objectfilenames.txt >> >> This change expands the fix for the similar issue on macosx, and prevents >> the fopen issue on aix. > > make/common/NativeCompilation.gmk line 1172: > >> 1170: ifeq ($(call isTargetOs, macosx), true) >> 1171: $1_LD_OBJ_ARG := `cat $$($1_OBJ_FILE_LIST)` >> 1172: else ifeq ($(call isTargetOs, aix), true) > > you could spare the `else ifeq` branch but rather use `ifeq ($(call > isTargetOs, macosx aix), true)` Good idea. Will make the change now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15743#discussion_r1327269502
