On Fri, 15 Sep 2023 16:56:48 GMT, Naoto Sato <[email protected]> wrote:
>> This PR is to incorporate the latest Unicode 15.1, which was released
>> yesterday. Besides the usual character data update, an upgraded
>> implementation of RegEx which reflects the Indic Conjunct Break specified in
>> the latest [Unicode Annex #29 ("Unicode Text
>> Segmentation")](https://unicode.org/reports/tr29/) is included. A
>> corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Update
> make/jdk/src/classes/build/tools/generateextraproperties/GenerateExtraProperties.java
>
> Co-authored-by: Andrey Turbanov <[email protected]>
> - Update
> make/jdk/src/classes/build/tools/generateextraproperties/GenerateExtraProperties.java
>
> Co-authored-by: Andrey Turbanov <[email protected]>
make/modules/java.base/gensrc/GensrcRegex.gmk line 35:
> 33: INDICCONJUNCTBREAKTEMP =
> $(MODULE_SRC)/share/classes/jdk/internal/util/regex/IndicConjunctBreak.java.template
> 34: INDICCONJUNCTBREAKPROPS =
> $(MODULE_SRC)/share/data/unicodedata/DerivedCoreProperties.txt
> 35: INDICCONJUNCTBREAKPARAMS = InCB\=Linker InCB\=Extend InCB\=Consonant
Please use `:=` for assignment unless you explicitly need lazy evaluation for
these variables. I can't see any reason to need that here.
I don't think you need to escape `=`. What happens if you don't?
make/modules/java.base/gensrc/GensrcRegex.gmk line 44:
> 42: $(INDICCONJUNCTBREAKPROPS) \
> 43: $(GENSRC_INDICCONJUNCTBREAK) \
> 44: $(INDICCONJUNCTBREAKPARAMS)
Please use 4 spaces after the initial tab for continuation indentation in
recipes (see point 2 and 6
https://openjdk.org/groups/build/doc/code-conventions.html).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15728#discussion_r1329103285
PR Review Comment: https://git.openjdk.org/jdk/pull/15728#discussion_r1329105914
