On Mon, 9 Oct 2023 12:53:18 GMT, Erik Joelsson <er...@openjdk.org> wrote:

> > I have added a basic test that verifies that symbols can be resolved by the 
> > internal jdk tooling that makes use of them, even after the name change for 
> > the .pdb files. It relies on the fact that on Windows/MSVC, native frames 
> > contains no function names when dumped in hs_err if pdb are not 
> > available/cannot be loaded. This is not true for all platforms (e.g. on 
> > Linux, function names are present in hs_err even when full symbols aren't 
> > available), so I have restricted this test to run on Windows only.
> 
> Adding a test seems nice, but I will have to defer to Hotspot people for 
> reviewing the validity, placement and tier/group inclusion of the new test. 
> My interpretation is that with the current placement and TEST.groups it will 
> be part of tier1.

Verified that the test passes in our internal build and test environment (which 
runs hotspot tests in tier1 on debug builds).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16039#issuecomment-1753677861

Reply via email to