On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato <[email protected]> wrote:
>> CLDR provides very few short names for time zones, such as PST/PDT. This
>> will typically end up substituting names from the COMPAT provider. Once the
>> COMPAT is removed, they will be displayed in the GMT format, i.e.,
>> GMT+XX:YY. Although some of the short names in the COMPAT provider are
>> somewhat questionable (less common ones are simply made up from the long
>> names by taking the initials), it would not be desirable for them to fall
>> back to the GMT format.
>> To mitigate the situation, CLDR can use the abbreviated names from the TZ
>> database, which contains legacy (major) short names as FORMAT. The CLDR
>> provider can use them instead of the GMT offset style. This enhancement is a
>> precursor to the future removal of the COMPAT provider.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Delay populating GMT format at runtime. Reflecting review comments.
make/modules/jdk.localedata/Gensrc.gmk line 39:
> 37: GENSRC_DIR := $(SUPPORT_OUTPUTDIR)/gensrc/jdk.localedata
> 38: CLDR_GEN_DONE := $(GENSRC_DIR)/_cldr-gensrc.marker
> 39: TZ_DATA_DIR := $(MODULE_SRC)/../java.base/share/data/tzdata
This seems like a bit of abuse of `$(MODULE_SRC)`. I thought we had a macro to
get the proper source path for another module, but if we do, I cannot find it
now.
If you feel up for it, I'd encourage you to change this to:
Suggestion:
TZ_DATA_DIR := $(call FindModuleSrc, java.base)/share/data/tzdata
and add
################################################################################
# Find source dir for module
# Param 1 - module name
FindModuleSrc = \
$(TOPDIR)/src/$(strip $1)
at a suitable place in `Utils.gmk`.
Otherwise, just replace it with:
TZ_DATA_DIR := $(TOPDIR)/src/java.base/share/data/tzdata
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16206#discussion_r1364065717
