On Thu, 26 Oct 2023 19:38:55 GMT, Joe Darcy <[email protected]> wrote:
>> Clarify the intention of tier 1 tests. I'll reflow the paragraph and >> regenerate the HTML file once the wording is agreed upon. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Implement review feedback. The jtreg generated timeStats.txt is useful to see the distribution. For the dev guide, I think it's good to say that tests that run in tier1 must run quickly but I don't think we can suggest 10s as a limit. It might be okay to say that 90% of tests in tier1 are expected to run in <10s and to think carefully when adding tests that take more than XX seconds, I don't know what XX, maybe 30, maybe 60. Right now there are a small number (in percentage terms) of tests running in tier1 with execution times more than a minute but some of these are with debug builds so they will be slower. So I think for the dev guide then some guidance is good. ------------- PR Comment: https://git.openjdk.org/jdk/pull/16384#issuecomment-1782396068
