On Thu, 26 Oct 2023 22:17:45 GMT, Claes Redestad <redes...@openjdk.org> wrote:

> The binutils build of libiberty is put in `$BINUTILS_INSTALL_DIR/lib64` on 
> some Linux distributions (e.g. Fedora, Oracle Linux), 
> `$BINUTILS_INSTALL_DIR/lib` on others (e.g. Ubuntu).
> 
> This PR suggest simply adding logic to look for `libiberty.a` in either 
> place, favoring `.../lib` like now.  Alternative solutions like adding an 
> explicit `--libdir=$BINUTILS_INSTALL_DIR/lib` in the binutils `configure` 
> setup was tested, but this option was ignored by the libibrerty build on the 
> binutils versions I've tried.

Looks good. Thanks for the quick fix!

-------------

Marked as reviewed by ihse (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16387#pullrequestreview-1701665042

Reply via email to