On Thu, 26 Oct 2023 15:41:35 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
> This looks good to me. > > One suggestion: to reduce code duplication and to make the code a bit safer > against accidental returns prior to fesetenv, I would have used a mark object > like this: Thanks. I take your point, but I think that might be something of a premature generalization right now. It would further complicate the code. > About the dlopen calls in the JDK, at SAP we were faced with similar problems > for other libc APIs (how to apply a fix to all of them). Some of these issues > we solved by redirecting all calls to libjvm. Others we solved manually, > in-place, with a lot of duplication. None of these sound appealing, but I > like the redirect-to-libjvm route somewhat, if Oracle can be convinced. > > A third option would be to use an interposition library with LD_PRELOAD. One > that overwrites dlopen and redirects to the real one. I don't see this to be > a practical solution but it may be valid for testing. Thanks, interesting stuff. ------------- PR Comment: https://git.openjdk.org/jdk/pull/10661#issuecomment-1782933843
