On Tue, 31 Oct 2023 14:42:22 GMT, Robbin Ehn <[email protected]> wrote:
>> The parse_caller_options handles the NULL case, so I forgot about the early
>> bailout.
>>
>> for (p = caller_options; p != NULL; ) {
>> }
>> *iop = '\0';
>>
>>
>> Sorry.
>
> Sorry again, long day:
>
> struct hsdis_app_data app_data;
> memset(&app_data, 0, sizeof(app_data));
>
> I knew I saw that somewhere.
> So if we don't parse at all (caller options NULL) it should be empty string
> in insn_options.
>
> That is the way we handle caller option NULL, no ?
Oh, I see.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16433#discussion_r1377901732
