On Thu, 2 Nov 2023 05:34:00 GMT, David Holmes <[email protected]> wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Try immediate bailout in os_windows.cpp
>
> src/hotspot/os/windows/os_windows.cpp line 2915:
>
>> 2913: goto result;
>> 2914: } else {
>> 2915: DWORD exceptionCode =
>> exceptionInfo->ExceptionRecord->ExceptionCode;
>
> No you brought the goto back! Why? goto's are bad.
Sorry, was experimenting different ways of doing it, and trying to change it
minimally. I guess the duplicated return statement is the way to go, as Thomas
suggested
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15955#discussion_r1379623655
