On Wed, 8 Nov 2023 16:25:59 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Jan Lahoda has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - Fixing tests. >> - Merge remote-tracking branch 'erikj/pull/16400' into JDK-8318913 >> - Build fixes >> - Include pre-release version in the module version. > > make/modules/jdk.compiler/Gendata.gmk line 101: > >> 99: >> 100: >> ################################################################################ >> 101: > > This too is provided by the framework, and is not needed in these "snippet" > makefiles. These new lines should still be deleted. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16400#discussion_r1388737415
