On Thu, 23 Nov 2023 15:08:42 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> The OpenJDK build system does not support building when the source code > resides on a path that contains a space. This requirement is documented in > the build instructions but not enforced by the configure script. > > This change adds an explicit checks to the wrapper `configure` script that > fail the build if the source code to be built is located in a directory who's > path contains a space character or the build path cannot be determined. > > This is a revival of the old patch in > https://github.com/openjdk/jdk/pull/10477, created in collaboration between > by @bondolo and myself. LGTM. As a contributor (though not much of my original contribution made it in to the final patch) I don't believe I can act as a reviewer. Thank you for bringing this change across the line! ------------- PR Comment: https://git.openjdk.org/jdk/pull/16798#issuecomment-1824673349
