On Sun, 3 Dec 2023 16:44:28 GMT, Markus Grönlund <mgron...@openjdk.org> wrote:
>> A question about "level". Is the intention that the value can be anything, >> e.g. some new event next month might use the values "1", "2, "3"? Just >> asking because ordinarily deprecated vs. terminally deprecated is very >> specific to the manner in which a program element is deprecated and I assume >> you don't want this event grabbing the general name for a very specific >> event setting. > >> A question about "level". Is the intention that the value can be anything, >> e.g. some new event next month might use the values "1", "2, "3"? Just >> asking because ordinarily deprecated vs. terminally deprecated is very >> specific to the manner in which a program element is deprecated and I assume >> you don't want this event grabbing the general name for a very specific >> event setting. > > Yes, the design is generic. An event control/setting to be used also for > other events. > Hi @mgronlun - sorry for opening a design discussion in PR :( > > I wonder - will this report each single one invocation of a deprecated method > conforming to the rules (JDK method called from non-JDK code)? Can this, > potentially, flood the recording if the deprecated method gets called from a > hot loop? Hi @jbachorik, it will only report one event per unique call site, during link time. Its not a function of hotness, only unique edge discovery. ------------- PR Comment: https://git.openjdk.org/jdk/pull/16931#issuecomment-1838269120
