On Fri, 15 Dec 2023 07:48:46 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:

>> Julian Waters has updated the pull request with a new target base due to a 
>> merge or a rebase. The incremental webrev excludes the unrelated changes 
>> brought in by the merge/rebase. The pull request contains five additional 
>> commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into patch-7
>>  - Revert vm_version_linux_riscv.cpp
>>  - vm_version_linux_riscv.cpp
>>  - allocation.cpp
>>  - 8310260
>
> src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp line 77:
> 
>> 75: #define read_csr(csr)                                           \
>> 76: ({                                                              \
>> 77:         unsigned long __v;                                      \
> 
> Can this change be made separately?  I'd like to have the C++17 switch be as 
> clean as possible.

No problem!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14988#discussion_r1427669495

Reply via email to