On Wed, 3 Jan 2024 17:39:56 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> bin/blessed-modifier-order.sh line 34: >> >>> 32: echo >>> 33: echo "See:" >>> 34: echo >>> "https://docs.oracle.com/javase/8/docs/api/java/lang/reflect/Modifier.html#toString-int-" >> >> Looking at the latest docs for Modifier#toString() >> it also needs a corresponding update >> https://download.java.net/java/early_access/jdk23/docs/api/java.base/java/lang/reflect/Modifier.html#toString(int) >> >> and if that is done, then we can keep referring to its javadoc. >> >> References to javadoc and jls both have problems of becoming stale over >> time. >> There is no way to reference the "latest" spec via a URL. > >> it also needs a corresponding update >> https://download.java.net/java/early_access/jdk23/docs/api/java.base/java/lang/reflect/Modifier.html#toString(int) > > From the preceding discussion, it follows that it cannot be done: > https://mail.openjdk.org/pipermail/core-libs-dev/2024-January/117381.html Thanks ... now I see ... --- When I originally wrote this script I recall hitting some false positives - a price we pay for having this modify comments. Don't blindly apply all suggestions! --- I don't recall considering "default". --- It seems we no longer have a single canonical reference for modifier order. (or more generally, a well-maintained high quality Java program style guide ...) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17242#discussion_r1441411821