On Fri, 12 Jan 2024 15:26:45 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

>> From the bug report:
>> 
>> jdk/.github/scripts/gen-test-results.sh is capable of capture hs_err_* file 
>> for erroneous and failed tests. They are also exposed under tag 
>> `<details><summary>View HotSpot error log</summary>`.
>> 
>> I think we can do the same thing for replay files. A replay file is 
>> automatically generated when compiler threads encounter a fatal error. 
>> sometimes, we can only trigger the compilation error on GHA. attached replay 
>> file is invaluable. 
>> 
>> ---
>> 
>> I have not figured out how to provoke a replay file on GHA, so this is 
>> untested, but since it is based on the hs_err logic I'm pretty confident 
>> that it works. If it turns out to be problematic, let's fix it in a follow 
>> up.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two 
> additional commits since the last revision:
> 
>  - Add a real change
>  - Trigger GHA with empty commit

(Sorry for the force push, I added a dummy commit locally touching real files, 
but I never intended to push it to this branch)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17392#issuecomment-1889512559

Reply via email to