On Fri, 12 Jan 2024 14:49:11 GMT, Julian Waters <jwat...@openjdk.org> wrote:
> [JDK-8323008](https://bugs.openjdk.org/browse/JDK-8323008) reports unwanted > autoconf flags being added to the command line, and solves the issue by > filtering out the added flags by force. This is not optimal however, as doing > so leaves the autoconf message that the flags were added still displaying > during the configure process, which is confusing. Instead, setting a couple > of fields to disable the autoconf internals responsible for the unwanted flag > is a cleaner solution I'm kind of on the fence for this one. On one hand filtering out stuff is really hacky, but so is setting internal undocumented variables. We have done some meddling with internal variable in a few places before, but I'd really like to keep that to a minumum. I'm not sure this is an improvement. I'd like to get input from other build folks on this. make/autoconf/toolchain.m4 line 355: > 353: OLD_PATH="$PATH" > 354: > 355: # autoconf can ass unwanted flags to CC and CXX based on what it deems > to be Suggestion: # autoconf can add unwanted flags to CC and CXX based on what it deems to be ------------- PR Comment: https://git.openjdk.org/jdk/pull/17401#issuecomment-1889569538 PR Review Comment: https://git.openjdk.org/jdk/pull/17401#discussion_r1450647162
